From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 20 Jul 2025 13:57:42 +0000 (+0200)
Subject: make the error messages clearer
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=033645a9145b8d88d9d2758a66b33864e3cb885f;p=thirdparty%2Ffreeradius-server.git

make the error messages clearer
---

diff --git a/src/modules/rlm_redis/rlm_redis.c b/src/modules/rlm_redis/rlm_redis.c
index 31bf5bd44f..e7eb9f527c 100644
--- a/src/modules/rlm_redis/rlm_redis.c
+++ b/src/modules/rlm_redis/rlm_redis.c
@@ -186,13 +186,15 @@ static ssize_t redis_xlat(void *instance, REQUEST *request, char const *fmt, cha
 		break;
 
 	default:
-		buffer_ptr = NULL;
-		break;
+		RDEBUG("rlm_redis (%s): Unsupported result %d from redis",
+		       inst->xlat_name, dissocket->reply->type);
+		ret = -1;
+		goto release;
 	}
 
-	if ((ret >= freespace) || (!buffer_ptr)) {
-		RDEBUG("rlm_redis (%s): Can't write result, insufficient space or unsupported result\n",
-		       inst->xlat_name);
+	if (ret >= freespace) {
+		RDEBUG("rlm_redis (%s): Can't write result (%zd), insufficient space (%zd)",
+		       inst->xlat_name, ret, freespace);
 		ret = -1;
 		goto release;
 	}