From: Mark Wielaard Date: Fri, 24 May 2019 19:51:31 +0000 (+0200) Subject: Fix memcheck/tests/linux/sys-copy_file_range open call (mode). X-Git-Tag: VALGRIND_3_16_0~283 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=033d013bebeb3471c0da47060deb9a5771e6c913;p=thirdparty%2Fvalgrind.git Fix memcheck/tests/linux/sys-copy_file_range open call (mode). sys-copy_file_range.c calls open with O_CREAT flag and so must provide a mode argument. valgrind memcheck actually caught this ommission on some arches (fedora rawhide i686 specifically). This is a small additional fixup for https://bugs.kde.org/show_bug.cgi?id=407218 --- diff --git a/memcheck/tests/linux/sys-copy_file_range.c b/memcheck/tests/linux/sys-copy_file_range.c index 589399c6bb..3022fa1c5c 100644 --- a/memcheck/tests/linux/sys-copy_file_range.c +++ b/memcheck/tests/linux/sys-copy_file_range.c @@ -12,7 +12,7 @@ int main(int argc, char **argv) struct stat stat; loff_t len, ret; - fd_in = open("copy_file_range_source", O_CREAT | O_RDWR); + fd_in = open("copy_file_range_source", O_CREAT | O_RDWR, 0644); if (fd_in == -1) { perror("open copy_file_range_source"); exit(EXIT_FAILURE);