From: Stephen Hemminger <shemming@brocade.com>
Date: Tue, 27 Oct 2015 06:46:20 +0000 (+0900)
Subject: qfq: fix parse_opt dead code
X-Git-Tag: v4.5.0~94
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=037660b3513aef53b98c2d0780d3781901986874;p=thirdparty%2Fiproute2.git

qfq: fix parse_opt dead code

Fix Coverity warning from dead code.
---

diff --git a/tc/q_qfq.c b/tc/q_qfq.c
index 05b4d84e2..0e026749a 100644
--- a/tc/q_qfq.c
+++ b/tc/q_qfq.c
@@ -38,16 +38,11 @@ static void explain_class(void)
 static int qfq_parse_opt(struct qdisc_util *qu, int argc, char **argv,
 			 struct nlmsghdr *n)
 {
-	while (argc > 0) {
-		if (matches(*argv, "help") == 0) {
-			explain();
-			return -1;
-		} else {
+	if (argc > 0) {
+		if (matches(*argv, "help") != 0)
 			fprintf(stderr, "What is \"%s\"?\n", *argv);
-			explain();
-			return -1;
-		}
-		argc--; argv++;
+		explain();
+		return -1;
 	}
 
 	return 0;