From: Daniel P. Berrange <berrange@redhat.com>
Date: Tue, 24 Sep 2013 15:46:44 +0000 (+0100)
Subject: Fix leak of serial value in xenFormatXM on OOM
X-Git-Tag: v1.1.3-rc1~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0377238fe8aa7d0a6faf7dbaa9a67c59cd1d58bc;p=thirdparty%2Flibvirt.git

Fix leak of serial value in xenFormatXM on OOM

If an OOM occurs in xenFormatXM when formatting to the
serial device value, the value is leaked.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/xenxs/xen_xm.c b/src/xenxs/xen_xm.c
index 7550a07abc..9e07f956d2 100644
--- a/src/xenxs/xen_xm.c
+++ b/src/xenxs/xen_xm.c
@@ -1959,8 +1959,10 @@ virConfPtr xenFormatXM(virConnectPtr conn,
                             break;
                         }
                     }
-                    if (xenFormatXMSerial(serialVal, chr) < 0)
+                    if (xenFormatXMSerial(serialVal, chr) < 0) {
+                        virConfFreeValue(serialVal);
                         goto cleanup;
+                    }
                 }
 
                 if (serialVal->list != NULL) {