From: Stephen Hemminger Date: Mon, 10 Dec 2007 19:34:40 +0000 (-0800) Subject: Fix off by one in nested attribute management. X-Git-Tag: v2.6.24-rc6~16 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=037c635eee994f6b29fc82931490e831d4a2ead2;p=thirdparty%2Fiproute2.git Fix off by one in nested attribute management. Fixes segv in: tc qdisc show dev eth1 due to uninitialized attribute table. Signed-off-by: Stephen Hemminger --- diff --git a/lib/libnetlink.c b/lib/libnetlink.c index 12883fe11..d13596fa2 100644 --- a/lib/libnetlink.c +++ b/lib/libnetlink.c @@ -632,6 +632,6 @@ int __parse_rtattr_nested_compat(struct rtattr *tb[], int max, struct rtattr *rt rta = RTA_DATA(rta) + RTA_ALIGN(len); return parse_rtattr_nested(tb, max, rta); } - memset(tb, 0, sizeof(struct rtattr *) * max); + memset(tb, 0, sizeof(struct rtattr *) * (max + 1)); return 0; }