From: Jim Jagielski <jim@apache.org>
Date: Wed, 9 Feb 2011 12:56:01 +0000 (+0000)
Subject: Squash error/warning about signed/unsigned comparison
X-Git-Tag: 2.3.11~83
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03ab1d60ca7d9f4109d5e71327bad61d796a0ba4;p=thirdparty%2Fapache%2Fhttpd.git

Squash error/warning about signed/unsigned comparison

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1068871 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/modules/proxy/mod_proxy_balancer.c b/modules/proxy/mod_proxy_balancer.c
index 03c752cddbc..bc8be80ea34 100644
--- a/modules/proxy/mod_proxy_balancer.c
+++ b/modules/proxy/mod_proxy_balancer.c
@@ -1332,18 +1332,21 @@ PROXY_DECLARE(apr_status_t) ap_proxy_update_members(proxy_balancer *b, server_re
 {
     proxy_worker **workers;
     int i;
-    unsigned int index;
+    int index;
     proxy_worker_shared *shm;
     if (b->s->wupdated <= b->wupdated)
         return APR_SUCCESS;
     /*
      * Look thru the list of workers in shm
-     * and see which one(s) we are lacking
+     * and see which one(s) we are lacking...
+     * again, the cast to unsigned int is safe
+     * since our upper limit is always max_workers
+     * which is int.
      */
     for (index = 0; index < b->max_workers; index++) {
         int found;
         apr_status_t rv;
-        if ((rv = storage->dptr(b->slot, index, (void *)&shm)) != APR_SUCCESS) {
+        if ((rv = storage->dptr(b->slot, (unsigned int)index, (void *)&shm)) != APR_SUCCESS) {
             ap_log_error(APLOG_MARK, APLOG_EMERG, rv, s, "worker slotmem_dptr failed");
             return APR_EGENERAL;
         }