From: Marcin Siodelski <marcin@isc.org>
Date: Tue, 17 May 2016 15:34:48 +0000 (+0200)
Subject: [4495] Fixed inefficient creation of DHCP Message Type option.
X-Git-Tag: trac4106_update_base~16^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03be5afa9b1c003382c34ba815b5af7d1abeafd9;p=thirdparty%2Fkea.git

[4495] Fixed inefficient creation of DHCP Message Type option.
---

diff --git a/src/lib/dhcp/pkt4.cc b/src/lib/dhcp/pkt4.cc
index 3c980b5205..bbd3e68763 100644
--- a/src/lib/dhcp/pkt4.cc
+++ b/src/lib/dhcp/pkt4.cc
@@ -276,9 +276,8 @@ void Pkt4::setType(uint8_t dhcp_type) {
         }
     } else {
         // There is no message type option yet, add it
-        std::vector<uint8_t> tmp(1, dhcp_type);
-        opt = OptionPtr(new OptionInt<uint8_t>(Option::V4, DHO_DHCP_MESSAGE_TYPE,
-                                               tmp.begin(), tmp.end()));
+        opt.reset(new OptionInt<uint8_t>(Option::V4, DHO_DHCP_MESSAGE_TYPE,
+                                         dhcp_type));
         addOption(opt);
     }
 }