From: Volker Lendecke Date: Thu, 7 Sep 2023 15:00:17 +0000 (+0200) Subject: tests: Create symlinks using posix extensions X-Git-Tag: tevent-0.16.0~700 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03ce770e8de7d9992abea577bcb8d6b471953e91;p=thirdparty%2Fsamba.git tests: Create symlinks using posix extensions This way we can run the tests and more easily put them into knownfail individually. Before this, everything went into the error category, which was not so easy to catch in something like knownfail. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- diff --git a/python/samba/tests/smb2symlink.py b/python/samba/tests/smb2symlink.py index 14f6056ac15..32d2f94b37e 100644 --- a/python/samba/tests/smb2symlink.py +++ b/python/samba/tests/smb2symlink.py @@ -34,10 +34,12 @@ class Smb2SymlinkTests(samba.tests.libsmb.LibsmbTests): self.server_ip, share, self.lp, - self.creds) + self.creds, + force_smb1=True) except NTSTATUSError as e: if e.args[0] != ntstatus.NT_STATUS_CONNECTION_RESET: raise + smb1.smb1_posix() share = samba.tests.env_get_var_value( "SMB2_SHARE", allow_missing=True) diff --git a/selftest/knownfail.d/symlink b/selftest/knownfail.d/symlink new file mode 100644 index 00000000000..64135666aec --- /dev/null +++ b/selftest/knownfail.d/symlink @@ -0,0 +1,4 @@ +^samba.tests.smb2symlink.samba.tests.smb2symlink.Smb2SymlinkTests.test_symlinkerror_directory +^samba.tests.smb2symlink.samba.tests.smb2symlink.Smb2SymlinkTests.test_symlinkerror_file +^samba.tests.smb2symlink.samba.tests.smb2symlink.Smb2SymlinkTests.test_symlinkerror_absolute_outside_share +^samba.tests.smb2symlink.samba.tests.smb2symlink.Smb2SymlinkTests.test_symlinkerror_absolute_inshare diff --git a/selftest/skip b/selftest/skip index e808367c00d..cc2fe8979e8 100644 --- a/selftest/skip +++ b/selftest/skip @@ -147,5 +147,4 @@ bench # don't run benchmarks in our selftest ^samba4.smb2.tcon.*\(ad_dc_ntvfs\)$ # Ignore ad_dc_ntvfs since this is a new test ^samba4.smb2.mkdir.*\(ad_dc_ntvfs\)$ # Ignore ad_dc_ntvfs since this is a new test ^samba.tests.reparsepoints.* -^samba.tests.smb2symlink.* ^samba3.blackbox.open-eintr.*