From: Andrew Bartlett <abartlet@samba.org>
Date: Wed, 20 Sep 2023 23:56:25 +0000 (+1200)
Subject: libcli/security: Make failure parsing where consumed == -1 clear
X-Git-Tag: tevent-0.16.0~412
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03d63fb09b8d4062f4a7f16e46941fbf2741b6a2;p=thirdparty%2Fsamba.git

libcli/security: Make failure parsing where consumed == -1 clear

This was caught by the next condition, but this is clearer.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/libcli/security/conditional_ace.c b/libcli/security/conditional_ace.c
index 2957dc20319..bc4f929ff6b 100644
--- a/libcli/security/conditional_ace.c
+++ b/libcli/security/conditional_ace.c
@@ -708,6 +708,9 @@ struct ace_condition_script *parse_conditional_ace(TALLOC_CTX *mem_ctx,
 			goto fail;
 		}
 
+		if (consumed < 0) {
+			goto fail;
+		}
 		if (consumed + i < i || consumed + i > data.length) {
 			goto fail;
 		}