From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Mon, 18 Jun 2018 19:53:38 +0000 (+0300)
Subject: master: Set listener fd to -1 after closing it
X-Git-Tag: 2.3.9~1700
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03d748a8511f13b71f1d72d01bb7502dfc056511;p=thirdparty%2Fdovecot%2Fcore.git

master: Set listener fd to -1 after closing it

The listener fds weren't used for anything afterwards, so it wasn't a
problem so far. The next commit requires it though.
---

diff --git a/src/master/service-listen.c b/src/master/service-listen.c
index 4f5c51465b..b96c5dc681 100644
--- a/src/master/service-listen.c
+++ b/src/master/service-listen.c
@@ -464,8 +464,7 @@ int services_listen_using(struct service_list *new_service_list,
 		if (old_listeners[j]->fd == -1)
 			continue;
 
-		if (close(old_listeners[j]->fd) < 0)
-			i_error("close(listener) failed: %m");
+		i_close_fd(&old_listeners[j]->fd);
 		switch (old_listeners[j]->type) {
 		case SERVICE_LISTENER_UNIX:
 		case SERVICE_LISTENER_FIFO: {