From: Jeremy Allison <jra@samba.org>
Date: Tue, 17 Jul 2007 02:17:23 +0000 (+0000)
Subject: r23910: We used to deny renames on the
X-Git-Tag: samba-misc-tags/initial-v3-2-unstable~698
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03e3d587468ce66044814a8a58308b2fe9ab5499;p=thirdparty%2Fsamba.git

r23910: We used to deny renames on the
source open for non-delete open.
Turns out this is not the case.
VL please test but this matches
Windows behaviour. (I'll add a
torture test tomorrow).
Jeremy.
---

diff --git a/source/smbd/reply.c b/source/smbd/reply.c
index e3ae0ef7f6a..2135299df06 100644
--- a/source/smbd/reply.c
+++ b/source/smbd/reply.c
@@ -1863,6 +1863,12 @@ static NTSTATUS can_rename(connection_struct *conn, files_struct *fsp,
 		return NT_STATUS_NO_SUCH_FILE;
 	}
 
+#if 0
+	/* We used to deny renames on the
+	 * source open for non-delete open.
+	 * Turns out this is not the case.
+	 * VL please test but this matches
+	 * Windows behaviour. JRA. */
 	if (S_ISDIR(pst->st_mode)) {
 		return NT_STATUS_OK;
 	}
@@ -1872,6 +1878,9 @@ static NTSTATUS can_rename(connection_struct *conn, files_struct *fsp,
 	}
 
 	return NT_STATUS_ACCESS_DENIED;
+#else
+	return NT_STATUS_OK;
+#endif
 }
 
 /*******************************************************************