From: Andreas Schneider <asn@samba.org>
Date: Fri, 1 Apr 2016 08:16:25 +0000 (+0200)
Subject: s4:libcli:smb2: Use constant time memcmp() to verify the signature
X-Git-Tag: talloc-2.1.7~222
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03e8152e39f2e0f931e9fd73f9e6a83d3a92fc1e;p=thirdparty%2Fsamba.git

s4:libcli:smb2: Use constant time memcmp() to verify the signature

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/libcli/smb2/signing.c b/source4/libcli/smb2/signing.c
index 6af7a6d4a11..8f8074b170d 100644
--- a/source4/libcli/smb2/signing.c
+++ b/source4/libcli/smb2/signing.c
@@ -111,7 +111,7 @@ NTSTATUS smb2_check_signature(struct smb2_request_buffer *buf, DATA_BLOB session
 
 	memcpy(buf->hdr+SMB2_HDR_SIGNATURE, sig, 16);
 
-	if (memcmp(res, sig, 16) != 0) {
+	if (memcmp_const_time(res, sig, 16) != 0) {
 		DEBUG(0,("Bad SMB2 signature for message of size %u\n", 
 			 (unsigned)buf->size-NBT_HDR_SIZE));
 		dump_data(0, sig, 16);