From: Francis Dupont <fdupont@isc.org>
Date: Thu, 7 Nov 2019 23:00:50 +0000 (+0100)
Subject: [960-mysql-connection-pool] Addressed some comments
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03fbdd0164e8794512a941cdd1a7abe462d8805f;p=thirdparty%2Fkea.git

[960-mysql-connection-pool] Addressed some comments
---

diff --git a/src/lib/dhcpsrv/mysql_lease_mgr.cc b/src/lib/dhcpsrv/mysql_lease_mgr.cc
index 41481cea50..c4edec0607 100644
--- a/src/lib/dhcpsrv/mysql_lease_mgr.cc
+++ b/src/lib/dhcpsrv/mysql_lease_mgr.cc
@@ -1685,13 +1685,15 @@ private:
 
 // MySqlLeaseContext Constructor
 
-MySqlLeaseContext::MySqlLeaseContext(const DatabaseConnection::ParameterMap& parameters) : conn_(parameters) {
+MySqlLeaseContext::
+MySqlLeaseContext(const DatabaseConnection::ParameterMap& parameters)
+    : conn_(parameters) {
 }
 
 // MySqlLeaseContextAlloc Constructor and Destructor
 
-MySqlLeaseMgr::MySqlLeaseContextAlloc::MySqlLeaseContextAlloc(const MySqlLeaseMgr& mgr)
-    : ctx_(), mgr_(mgr) {
+MySqlLeaseMgr::MySqlLeaseContextAlloc::
+MySqlLeaseContextAlloc(const MySqlLeaseMgr& mgr) : ctx_(), mgr_(mgr) {
     if (MultiThreadingMgr::instance().getMode()) {
         {
             lock_guard<mutex> lock(mgr_.pool_->mutex_);
@@ -1707,7 +1709,7 @@ MySqlLeaseMgr::MySqlLeaseContextAlloc::MySqlLeaseContextAlloc(const MySqlLeaseMg
         if (mgr_.pool_->pool_.empty()) {
             isc_throw(Unexpected, "No available MySQL lease context?!");
         }
-        ctx_ = mgr_.pool_->pool_[0];
+        ctx_ = mgr_.pool_->pool_.back();
     }
 }
 
diff --git a/src/lib/dhcpsrv/mysql_lease_mgr.h b/src/lib/dhcpsrv/mysql_lease_mgr.h
index 1c335e018a..c89a12c7a9 100644
--- a/src/lib/dhcpsrv/mysql_lease_mgr.h
+++ b/src/lib/dhcpsrv/mysql_lease_mgr.h
@@ -911,7 +911,7 @@ private:
         /// @brief The context
         MySqlLeaseContextPtr ctx_;
 
-        private:
+    private:
         /// @brief The manager
         const MySqlLeaseMgr& mgr_;
     };