From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Wed, 24 Aug 2016 15:08:53 +0000 (+0200)
Subject: don't use kr_crypto_reinit()
X-Git-Tag: v1.2.0-rc1~102^2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04065fcd97513e0b1e2acc7d2e2ea4311b0d312e;p=thirdparty%2Fknot-resolver.git

don't use kr_crypto_reinit()

We called kr_crypto_init() just before forking and then _reinit() in
all children, but we never did any cryptography in-between - better
initialize after forking.

Note: the function is KR_EXPORT.  It might not be useful anymore, but
its removal would require bumping libkres soname.
---

diff --git a/daemon/main.c b/daemon/main.c
index 884adcbaf..012ef75c0 100644
--- a/daemon/main.c
+++ b/daemon/main.c
@@ -259,7 +259,6 @@ static int fork_workers(fd_array_t *ipc_set, int forks)
 			array_clear(*ipc_set);
 			array_push(*ipc_set, sv[0]);
 			close(sv[1]);
-			kr_crypto_reinit();
 			return forks;
 		/* Parent process */
 		} else {
@@ -541,8 +540,6 @@ int main(int argc, char **argv)
 	 }
 #endif
 
-	kr_crypto_init();
-
 	/* Connect forks with local socket */
 	fd_array_t ipc_set;
 	array_init(ipc_set);
@@ -552,6 +549,8 @@ int main(int argc, char **argv)
 		return EXIT_FAILURE;
 	}
 
+	kr_crypto_init();
+
 	/* Create a server engine. */
 	knot_mm_t pool = {
 		.ctx = mp_new (4096),