From: Dylan William Hardison <dylan@hardison.net>
Date: Tue, 20 Nov 2018 23:20:03 +0000 (-0500)
Subject: Bug 1508201 - move inline js on the buglist out to a separate file
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0414625c9cfc99abac0e1d66aeb794d31ff4ac68;p=thirdparty%2Fbugzilla.git

Bug 1508201 - move inline js on the buglist out to a separate file
---

diff --git a/js/buglist.js b/js/buglist.js
new file mode 100644
index 000000000..2e63775af
--- /dev/null
+++ b/js/buglist.js
@@ -0,0 +1,23 @@
+function SetCheckboxes(value) {
+  let elements = document.querySelectorAll("input[type='checkbox'][name^='id_']");
+  for (let item of elements) {
+    item.checked = value;
+  }
+}
+
+document.addEventListener("DOMContentLoaded", () => {
+  let check_all = document.getElementById("check_all");
+  let uncheck_all = document.getElementById("uncheck_all");
+  if (check_all) {
+    check_all.addEventListener("click", event => {
+      SetCheckboxes(true);
+      event.preventDefault();
+    });
+  }
+  if (uncheck_all) {
+    uncheck_all.addEventListener("click", event => {
+      SetCheckboxes(false);
+      event.preventDefault();
+    });
+  }
+});
diff --git a/template/en/default/list/edit-multiple.html.tmpl b/template/en/default/list/edit-multiple.html.tmpl
index 1128a5e8e..8224a3040 100644
--- a/template/en/default/list/edit-multiple.html.tmpl
+++ b/template/en/default/list/edit-multiple.html.tmpl
@@ -27,23 +27,8 @@
 [% dontchange = "--do_not_change--" %]
 <input type="hidden" name="dontchange" value="[% dontchange FILTER html %]">
 <input type="hidden" name="token" value="[% token FILTER html %]">
-
-<script [% script_nonce FILTER none %]>
-  function SetCheckboxes(value) {
-      var elements = document.forms.changeform.getElementsByTagName('input'),
-          numelements = elements.length,
-          item, i;
-      for (i = 0; i < numelements; i++) {
-          item = elements[i];
-          if (item.type === 'checkbox' && item.name.match(/^id_/)) {
-            item.checked = value;
-          }
-      }
-  }
-  document.write(' <input type="button" name="uncheck_all" value="Uncheck All" onclick="SetCheckboxes(false);">');
-  document.write(' <input type="button" name="check_all" value="Check All" onclick="SetCheckboxes(true);">');
-</script>
-
+<input type="button" id="uncheck_all" name="uncheck_all" value="Uncheck All">
+<input type="button" id="check_all" name="check_all" value="Check All">
 <hr>
 
 <p style="font-size:smaller">
diff --git a/template/en/default/list/list.html.tmpl b/template/en/default/list/list.html.tmpl
index e8fc9083a..13ebacf0f 100644
--- a/template/en/default/list/list.html.tmpl
+++ b/template/en/default/list/list.html.tmpl
@@ -50,7 +50,7 @@
   generate_api_token = dotweak
   style = style
   atomlink = basepath _ "buglist.cgi?$urlquerypart&title=$url_filtered_title&ctype=atom"
-  javascript_urls = [ "js/util.js", "js/field.js" ]
+  javascript_urls = [ "js/util.js", "js/field.js", "js/buglist.js" ]
   style_urls = [ "skins/standard/buglist.css" ]
   doc_section = "query.html#list"
 %]