From: Joseph Sutton Date: Tue, 1 Feb 2022 07:57:22 +0000 (+1300) Subject: tests/krb5: Add account to cleanup list before adding it to database X-Git-Tag: tevent-0.12.0~380 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=042137f8fa5f9672ace7e26969748716ca83baf9;p=thirdparty%2Fsamba.git tests/krb5: Add account to cleanup list before adding it to database This ensures accounts are still cleaned up if a test fails before adding it to the cleanup list. Signed-off-by: Joseph Sutton Reviewed-by: Stefan Metzmacher --- diff --git a/python/samba/tests/krb5/kdc_base_test.py b/python/samba/tests/krb5/kdc_base_test.py index 2d3123109c8..7a58f2bbbef 100644 --- a/python/samba/tests/krb5/kdc_base_test.py +++ b/python/samba/tests/krb5/kdc_base_test.py @@ -299,6 +299,8 @@ class KDCBaseTest(RawKerberosTest): details["userPrincipalName"] = upn if additional_details is not None: details.update(additional_details) + # Save the account name so it can be deleted in tearDownClass + self.accounts.append(dn) samdb.add(details) creds = KerberosCredentials() @@ -314,9 +316,6 @@ class KDCBaseTest(RawKerberosTest): creds.set_dn(ldb.Dn(samdb, dn)) creds.set_upn(upn) creds.set_spn(spn) - # - # Save the account name so it can be deleted in tearDownClass - self.accounts.append(dn) self.creds_set_enctypes(creds)