From: Harlan Stenn <stenn@ntp.org>
Date: Sat, 5 Dec 2015 09:40:44 +0000 (+0000)
Subject: CID 1341684: Nit in tests/ntpd/t-ntp_signd.c.  HStenn.
X-Git-Tag: NTP_4_3_87~1^2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04217236c0999cc307f9c31701116e03e6b884ca;p=thirdparty%2Fntp.git

CID 1341684: Nit in tests/ntpd/t-ntp_signd.c.  HStenn.

bk: 5662b11csHWHbg93r9HMCxLwzF1P0A
---

diff --git a/ChangeLog b/ChangeLog
index 688ee3373..21c8cf7ac 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -10,6 +10,7 @@
 * CID 1341536: Resource leak in tests/ntpd/t-ntp_signd.c.  HStenn.
 * CID 1341537: Resource leak in tests/ntpd/t-ntp_signd.c.  HStenn.
 * CID 1341538: Memory leak in tests/ntpd/ntp_prio_q.c:262.  HStenn.
+* CID 1341684: Nit in tests/ntpd/t-ntp_signd.c.  HStenn.
 * [Bug 2829] Look at pipe_fds in ntpd.c  (did so. perlinger@ntp.org)
 * [Bug 2887] stratum -1 config results as showing value 99
   - fudge stratum only accepts values [0..16]. perlinger@ntp.org
diff --git a/tests/ntpd/t-ntp_signd.c b/tests/ntpd/t-ntp_signd.c
index aaaec0cb3..534c940d2 100644
--- a/tests/ntpd/t-ntp_signd.c
+++ b/tests/ntpd/t-ntp_signd.c
@@ -164,6 +164,10 @@ test_send_via_ntp_signd(void)
 	int	flags = 0;
 	struct pkt  *xpkt = (struct pkt *) malloc(sizeof(struct pkt)); //defined in ntp.h
 
+	TEST_ASSERT_NOT_NULL(rbufp);
+	TEST_ASSERT_NOT_NULL(xpkt);
+	memset(xpkt, 0, sizeof(struct pkt));
+
 	//send_via_ntp_signd(NULL,NULL,NULL,NULL,NULL);	//doesn't work
 	/*
 	** Send the xpkt to Samba, read the response back in rbufp