From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 13 Jan 2012 13:46:49 +0000 (+0100)
Subject: Note sock->interface
X-Git-Tag: release_2_2_0~204
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=042ba30b6c5adae2fab21e44d50d5c55b9016d5d;p=thirdparty%2Ffreeradius-server.git

Note sock->interface
---

diff --git a/src/main/dhcpd.c b/src/main/dhcpd.c
index 6424c4c52fe..619254b468e 100644
--- a/src/main/dhcpd.c
+++ b/src/main/dhcpd.c
@@ -446,6 +446,10 @@ static int dhcp_socket_parse(CONF_SECTION *cs, rad_listen_t *this)
 
 	sock = this->data;
 
+	if (!sock->interface) {
+		DEBUG("WARNING: No \"interface\" setting is defined.  Only unicast DHCP will work.");
+	}
+
 	/*
 	 *	See whether or not we enable broadcast packets.
 	 */
@@ -484,8 +488,6 @@ static int dhcp_socket_parse(CONF_SECTION *cs, rad_listen_t *this)
 			      &sock->suppress_responses, NULL);
 	}
 	
-	if (!sock->src_interface) sock->src_interface = strdup(sock->interface);
-
 	cp = cf_pair_find(cs, "src_interface");
 	if (cp) {
 		cf_item_parse(cs, "src_interface", PW_TYPE_STRING_PTR,
@@ -494,6 +496,10 @@ static int dhcp_socket_parse(CONF_SECTION *cs, rad_listen_t *this)
                 sock->src_interface = sock->interface;
         }
 
+	if (!sock->src_interface && sock->interface) {
+		sock->src_interface = strdup(sock->interface);
+	}
+
 	cp = cf_pair_find(cs, "src_ipaddr");
 	if (cp) {
 		memset(&sock->src_ipaddr, 0, sizeof(sock->src_ipaddr));