From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 17 Sep 2013 09:01:34 +0000 (+0200)
Subject: qemu: Fix memleak after commit 59898a88ce8431bd3ea249b8789edc2ef9985827
X-Git-Tag: CVE-2013-4311~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=044e3e75248f0346f9dfd181a90f7d16d69ed482;p=thirdparty%2Flibvirt.git

qemu: Fix memleak after commit 59898a88ce8431bd3ea249b8789edc2ef9985827

If the ABI compatibility check with the "migratable" user XML is
successful, we would leak the originally parsed XML from the user that
would not be used in this case.

Reported by Ján Tomko.
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 75348a1404..0763f9b6d5 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5274,6 +5274,8 @@ qemuDomainSaveImageOpen(virQEMUDriverPtr driver,
             /* use the user provided XML */
             newdef = def2;
             def2 = NULL;
+        } else {
+            virDomainDefFree(def2);
         }
 
         virDomainDefFree(def);