From: Jeremy Allison <jra@samba.org>
Date: Fri, 7 Feb 2020 00:20:59 +0000 (-0800)
Subject: s3: DFS: Don't allow link deletion on a read-only share.
X-Git-Tag: ldb-2.1.1~64
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0450593e38d62fe0b925d789486517ade31fe3c6;p=thirdparty%2Fsamba.git

s3: DFS: Don't allow link deletion on a read-only share.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14269

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index fd58a255869..8f355d3a2c9 100644
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -1504,6 +1504,17 @@ bool remove_msdfs_link(const struct junction_map *jucn,
 		return false;
 	}
 
+	if (!CAN_WRITE(conn)) {
+		const struct loadparm_substitution *lp_sub =
+			loadparm_s3_global_substitution();
+		int snum = lp_servicenumber(jucn->service_name);
+
+		DBG_WARNING("Can't remove DFS entry on read-only share %s\n",
+			lp_servicename(frame, lp_sub, snum));
+		TALLOC_FREE(frame);
+		return false;
+	}
+
 	smb_fname = synthetic_smb_fname(frame,
 					path,
 					NULL,