From: Daniel P. Berrange <berrange@redhat.com>
Date: Mon, 28 Apr 2014 13:17:15 +0000 (+0100)
Subject: Remove bogus ATTRIBUTE_NONNULL from virFirewallAddRuleFull
X-Git-Tag: v1.2.4-rc2~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04515a3438fa52352bec6f0c61fc990895e37f60;p=thirdparty%2Flibvirt.git

Remove bogus ATTRIBUTE_NONNULL from virFirewallAddRuleFull

The virFirewallAddRuleFull method originally had a single
compulsory virFirewallQueryCallback parameter. During dev
work though the ignoreErrors parameter was added and the
callback parameter made optional. The ATTRIBUTE_NONNULL
annotation was never removed though.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/src/util/virfirewall.h b/src/util/virfirewall.h
index 5ca66fa5a3..1129219716 100644
--- a/src/util/virfirewall.h
+++ b/src/util/virfirewall.h
@@ -59,7 +59,7 @@ virFirewallRulePtr virFirewallAddRuleFull(virFirewallPtr firewall,
                                           virFirewallQueryCallback cb,
                                           void *opaque,
                                           ...)
-    ATTRIBUTE_NONNULL(3) ATTRIBUTE_SENTINEL;
+    ATTRIBUTE_SENTINEL;
 
 void virFirewallRemoveRule(virFirewallPtr firewall,
                            virFirewallRulePtr rule);