From: Karel Zak <kzak@redhat.com>
Date: Tue, 31 Jan 2012 13:50:22 +0000 (+0100)
Subject: login: comparing an array to null is not useful [coverity scan]
X-Git-Tag: v2.21-rc2~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0468860d1a2f100b3314ac95b703a42409b99f50;p=thirdparty%2Futil-linux.git

login: comparing an array to null is not useful [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/login-utils/login.c b/login-utils/login.c
index 3a904f2f88..5ff8802d1e 100644
--- a/login-utils/login.c
+++ b/login-utils/login.c
@@ -452,7 +452,7 @@ static void log_btmp(struct login_context *cxt)
 
 	if (cxt->hostname) {
 		xstrncpy(ut.ut_host, cxt->hostname, sizeof(ut.ut_host));
-		if (cxt->hostaddress && *cxt->hostaddress)
+		if (*cxt->hostaddress)
 			memcpy(&ut.ut_addr_v6, cxt->hostaddress,
 			       sizeof(ut.ut_addr_v6));
 	}
@@ -604,7 +604,7 @@ static void log_utmp(struct login_context *cxt)
 	ut.ut_pid = cxt->pid;
 	if (cxt->hostname) {
 		xstrncpy(ut.ut_host, cxt->hostname, sizeof(ut.ut_host));
-		if (cxt->hostaddress && *cxt->hostaddress)
+		if (*cxt->hostaddress)
 			memcpy(&ut.ut_addr_v6, cxt->hostaddress,
 			       sizeof(ut.ut_addr_v6));
 	}