From: Mike Bayer Date: Fri, 10 Apr 2020 18:28:54 +0000 (-0400) Subject: Repair CTE a in b tests X-Git-Tag: rel_1_4_0b1~404 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=046934083bbf0193e29c990bed0527fdac56f9a8;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git Repair CTE a in b tests In I27cac9bd265c86ff2a3381ff9f844f60ef991cfc we modernized the default tests and converted the "a in b" CTE tests to combinations, however apparently the existing tests were not testing all combinations and had repeats instead. The combinations decorator has made this much easier to spot, so use the correct combinations that were originally intended. Change-Id: Icd904887bff00c31525497d0b1508fabaf052dc9 --- diff --git a/test/sql/test_defaults.py b/test/sql/test_defaults.py index 52e73b2233..0a50a6356c 100644 --- a/test/sql/test_defaults.py +++ b/test/sql/test_defaults.py @@ -858,8 +858,8 @@ class CTEDefaultTest(fixtures.TablesTest): @testing.combinations( ("update", "select", testing.requires.ctes_on_dml), - ("update", "select", testing.requires.ctes_on_dml), - ("update", "select", testing.requires.ctes_on_dml), + ("delete", "select", testing.requires.ctes_on_dml), + ("insert", "select", testing.requires.ctes_on_dml), ("select", "update"), ("select", "insert"), argnames="a, b",