From: Caleb Cauthon Date: Sun, 1 Nov 2015 01:51:16 +0000 (-0500) Subject: Show arguments in deprecation warnings. X-Git-Tag: 2.11.0~28^2~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=046fab0d7288d01ea807207bca1ac1e87135c303;p=thirdparty%2Fmoment.git Show arguments in deprecation warnings. --- diff --git a/src/lib/utils/deprecate.js b/src/lib/utils/deprecate.js index df4286b84..44326c072 100644 --- a/src/lib/utils/deprecate.js +++ b/src/lib/utils/deprecate.js @@ -12,7 +12,7 @@ export function deprecate(msg, fn) { return extend(function () { if (firstTime) { - warn(msg + '\n' + (new Error()).stack); + warn(msg + '\nArguments: ' + Array.prototype.slice.call(arguments).join(', ') + '\n' + (new Error()).stack); firstTime = false; } return fn.apply(this, arguments); diff --git a/src/test/moment/deprecate.js b/src/test/moment/deprecate.js new file mode 100644 index 000000000..455ab9fdd --- /dev/null +++ b/src/test/moment/deprecate.js @@ -0,0 +1,13 @@ +import { module, test, expect } from '../qunit'; +import { deprecate } from '../../lib/utils/deprecate'; +import moment from '../../moment'; + +module('deprecate'); + +test('deprecate', function (assert) { + var fn = function () {}; + var deprecatedFn = deprecate('testing deprecation', fn); + deprecatedFn(); + + expect(0); +}); diff --git a/src/test/qunit.js b/src/test/qunit.js index 5a43df461..b6d9875de 100644 --- a/src/test/qunit.js +++ b/src/test/qunit.js @@ -4,6 +4,8 @@ import moment from '../moment'; export var test = QUnit.test; +export var expect = QUnit.expect; + export function module (name, lifecycle) { QUnit.module(name, { setup : function () {