From: Michael Adam <obnox@samba.org>
Date: Thu, 12 Apr 2012 06:18:04 +0000 (+0200)
Subject: s3:registry: don't leak the old contents when updating the value cache
X-Git-Tag: samba-4.0.0alpha20~86
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04aa303fb11ed7b275a1268f932bb79209f77787;p=thirdparty%2Fsamba.git

s3:registry: don't leak the old contents when updating the value cache

Signed-off-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index d1b43ba3e89..712cbda7888 100644
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -89,6 +89,7 @@ static WERROR fill_value_cache(struct registry_key *key)
 		}
 	}
 
+	TALLOC_FREE(key->values);
 	werr = regval_ctr_init(key, &(key->values));
 	W_ERROR_NOT_OK_RETURN(werr);