From: Hans-Peter Nilsson Date: Fri, 17 Jun 2011 11:24:55 +0000 (+0000) Subject: re PR rtl-optimization/48542 (unchanged variables in code which calls setjmp may... X-Git-Tag: releases/gcc-4.3.6~50 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04c462aab45a3296d5efb539d4479717b12e7eac;p=thirdparty%2Fgcc.git re PR rtl-optimization/48542 (unchanged variables in code which calls setjmp may be clobbered (including the return-address)) PR rtl-optimization/48542 * reload.c (find_equiv_reg): Stop looking when finding a setjmp-type call. * reload1.c (reload_as_needed): Invalidate all reload registers when crossing a setjmp-type call. From-SVN: r175146 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 27eb7e8df3e9..eb0f7f9b8cc5 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,14 @@ +2011-06-17 Hans-Peter Nilsson + + Backport from mainline + 2011-06-17 Hans-Peter Nilsson + + PR rtl-optimization/48542 + * reload.c (find_equiv_reg): Stop looking when finding a + setjmp-type call. + * reload1.c (reload_as_needed): Invalidate all reload + registers when crossing a setjmp-type call. + 2011-06-05 Kaz Kojima Backport from mainline diff --git a/gcc/reload.c b/gcc/reload.c index 5e33ff4b8430..cfe6be8c5643 100644 --- a/gcc/reload.c +++ b/gcc/reload.c @@ -6716,6 +6716,15 @@ find_equiv_reg (rtx goal, rtx insn, enum reg_class class, int other, || num > PARAM_VALUE (PARAM_MAX_RELOAD_SEARCH_INSNS)) return 0; + /* Don't reuse register contents from before a setjmp-type + function call; on the second return (from the longjmp) it + might have been clobbered by a later reuse. It doesn't + seem worthwhile to actually go and see if it is actually + reused even if that information would be readily available; + just don't reuse it across the setjmp call. */ + if (CALL_P (p) && find_reg_note (p, REG_SETJMP, NULL_RTX)) + return 0; + if (NONJUMP_INSN_P (p) /* If we don't want spill regs ... */ && (! (reload_reg_p != 0 diff --git a/gcc/reload1.c b/gcc/reload1.c index d0fec9b29af9..8e6dbbc61a51 100644 --- a/gcc/reload1.c +++ b/gcc/reload1.c @@ -4311,6 +4311,13 @@ reload_as_needed (int live_known) { AND_COMPL_HARD_REG_SET (reg_reloaded_valid, call_used_reg_set); AND_COMPL_HARD_REG_SET (reg_reloaded_valid, reg_reloaded_call_part_clobbered); + + /* If this is a call to a setjmp-type function, we must not + reuse any reload reg contents across the call; that will + just be clobbered by other uses of the register in later + code, before the longjmp. */ + if (find_reg_note (insn, REG_SETJMP, NULL_RTX)) + CLEAR_HARD_REG_SET (reg_reloaded_valid); } }