From: Fred Morcos <fred.morcos@open-xchange.com>
Date: Mon, 27 Nov 2023 10:51:08 +0000 (+0100)
Subject: Meson: Refactor sqlite3 handling for module-gsqlite3
X-Git-Tag: rec-5.1.0-alpha1~80^2~36
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04c9ac7de46d3f421c5165857a9c16ba1a4d1b92;p=thirdparty%2Fpdns.git

Meson: Refactor sqlite3 handling for module-gsqlite3
---

diff --git a/meson.build b/meson.build
index 918c4f5cd0..9ca9b29ed5 100644
--- a/meson.build
+++ b/meson.build
@@ -72,6 +72,7 @@ subdir('meson' / 'socket-dir')              # Socket Dir
 subdir('meson' / 'various-functions')       # Various Functions
 subdir('meson' / 'various-headers')         # Various Headers
 subdir('meson' / 'yaml-cpp')                # YAML C++
+subdir('meson' / 'sqlite3')                 # Sqlite3
 
 # Manpages
 # if not fs.exists('docs' / 'pdns_server.1') and not python_have_venv
@@ -119,6 +120,7 @@ deps = [
   dep_protozero,
   dep_yahttp,
   dep_yaml_cpp,
+  dep_sqlite3,
 ]
 
 # Modules
@@ -128,7 +130,6 @@ all_modules = {
   'gmysql':   {'deps': ['mysql'],                       'exts': []},
   'godbc':    {'deps': ['odbc'],                        'exts': []},
   'gpgsql':   {'deps': ['pgsql'],                       'exts': []},
-  'gsqlite3': {'deps': ['sqlite3'],                     'exts': []},
   'ldap':     {'deps': ['ldap'],                        'exts': []},
   'lua2':     {'deps': [],                              'exts': []},
   'remote':   {'deps': ['prog-curl', 'zeromq'],         'exts': []},
@@ -163,9 +164,6 @@ foreach module_name, module_props: all_modules
   endforeach
 endforeach
 
-# Add the sqlite3 dependency for the bind and gsqlite3 backends and pdnsutil.
-deps += get_variable('dep_sqlite3', dependency('', required: false))
-
 subdir('pdns')
 
 selected_modules = []
diff --git a/meson/sqlite3/meson.build b/meson/sqlite3/meson.build
index e69f4117a9..cbad2265f3 100644
--- a/meson/sqlite3/meson.build
+++ b/meson/sqlite3/meson.build
@@ -1,10 +1,13 @@
-dep_sqlite3 = dependency('sqlite3', required: true)
+dep_sqlite3 = dependency('', required: false)
+
+if get_option('module-gsqlite3') != 'disabled'
+  dep_sqlite3 = dependency('sqlite3', required: true)
+endif
 
 conf.set('HAVE_SQLITE3', dep_sqlite3.found(), description: 'Sqlite3')
 conf.set('SQLITE3', dep_sqlite3.found(), description: 'Sqlite3')
 
 summary('SQLite3', dep_sqlite3.found(), bool_yn: true, section: 'SQLite3')
-
 if dep_sqlite3.found()
   summary('Version', dep_sqlite3.version(), section: 'SQLite3')
 endif
diff --git a/pdns/meson.build b/pdns/meson.build
index b8b80a9923..54146e2278 100644
--- a/pdns/meson.build
+++ b/pdns/meson.build
@@ -155,7 +155,7 @@ conditional_sources = {
   'ssqlite3': {
     'sources': ['ssqlite3.cc'],
     'headers': ['ssqlite3.hh'],
-    'condition': get_variable('dep_sqlite3', dependency('', required: false)).found(),
+    'condition': dep_sqlite3.found(),
   },
   'minicurl': {
     'sources': ['minicurl.cc'],