From: Shivani Bhardwaj <shivani@oisf.net>
Date: Wed, 26 Mar 2025 06:04:11 +0000 (+0530)
Subject: util/lua: change arg name to reflect correctness
X-Git-Tag: suricata-8.0.0-beta1~130
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04c9e16348e4c4642d605150af9e467e3b18a805;p=thirdparty%2Fsuricata.git

util/lua: change arg name to reflect correctness

lua fns do not care about the argument count, they work with the index of
the item in the stack. Before library, there was just one item on the stack
so it worked out, however, with the library, the first item in the stack is
the library userdata, so, the fn would fail with the existing hard coded
setting of 1 for argc which can easily be confused with the number of
arguments passed to the fn.
---

diff --git a/src/util-lua-common.c b/src/util-lua-common.c
index cfd349bc8e..f24863f172 100644
--- a/src/util-lua-common.c
+++ b/src/util-lua-common.c
@@ -63,12 +63,12 @@ int LuaCallbackError(lua_State *luastate, const char *msg)
     return 2;
 }
 
-const char *LuaGetStringArgument(lua_State *luastate, int argc)
+const char *LuaGetStringArgument(lua_State *luastate, int idx)
 {
     /* get argument */
-    if (!lua_isstring(luastate, argc))
+    if (!lua_isstring(luastate, idx))
         return NULL;
-    const char *str = lua_tostring(luastate, argc);
+    const char *str = lua_tostring(luastate, idx);
     if (str == NULL)
         return NULL;
     if (strlen(str) == 0)