From: Jeremy Allison Date: Mon, 26 Aug 2019 16:54:06 +0000 (-0700) Subject: s3: libsmbclient: Ensure SMBC_readdir_ctx() also updates the readdirplus pointers. X-Git-Tag: samba-4.9.14~12 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04cb3d3ee138c8ec943a5424c82fa7ff47203703;p=thirdparty%2Fsamba.git s3: libsmbclient: Ensure SMBC_readdir_ctx() also updates the readdirplus pointers. If we are returning file entries, we have a duplicate list in dirplus. Update dirplus_next also so readdir and readdirplus are kept in sync. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094 Signed-off-by: Jeremy Allison Reviewed-by: Ralph Böhme (cherry picked from commit 4bca8e097f5a909c628daa4dbfa932ddc1725ebc) --- diff --git a/source3/libsmb/libsmb_dir.c b/source3/libsmb/libsmb_dir.c index ff19ed57f14..35215fdfbb5 100644 --- a/source3/libsmb/libsmb_dir.c +++ b/source3/libsmb/libsmb_dir.c @@ -1173,6 +1173,17 @@ SMBC_readdir_ctx(SMBCCTX *context, dir->dir_next = dir->dir_next->next; + /* + * If we are returning file entries, we + * have a duplicate list in dirplus. + * + * Update dirplus_next also so readdir and + * readdirplus are kept in sync. + */ + if (dir->dirplus_list != NULL) { + dir->dirplus_next = dir->dirplus_next->next; + } + TALLOC_FREE(frame); return dirp; }