From: Eric Wong <e@80x24.org>
Date: Wed, 11 Oct 2023 07:20:55 +0000 (+0000)
Subject: import: cat_blob is a no-op w/o live fast-import
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04e0bf7b622dfbc8fdf85425f3bc9af19531f7c0;p=thirdparty%2Fpublic-inbox.git

import: cat_blob is a no-op w/o live fast-import

cat_blob is a fallback for handling files which haven't made it
onto disk to be readable by `git cat-file'.  Thus spawning a new
fast-import process to retrieve a blob is pointless, as cat_blob
is only used as a last resort when `git cat-file' fails.
---

diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 894ba8180..6bb2c66d8 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -123,7 +123,7 @@ sub _cat_blob ($$) {
 
 sub cat_blob {
 	my ($self, $oid) = @_;
-	_cat_blob(gfi_start($self), $oid);
+	_cat_blob($self->{io} // return, $oid);
 }
 
 sub check_remove_v1 {