From: Jim Meyering <meyering@redhat.com>
Date: Thu, 4 Feb 2010 11:49:53 +0000 (+0100)
Subject: virDomainChrDefParseXML: don't leak upon invalid input
X-Git-Tag: v0.7.7~236
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=04ebf058d506c2a1a4bb1754726558410ff79270;p=thirdparty%2Flibvirt.git

virDomainChrDefParseXML: don't leak upon invalid input

* src/conf/domain_conf.c (virDomainChrDefParseXML): Don't leak a
virDomainChrDef buffer upon "unknown target type for char device" error.
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 766993c586..306776de1d 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -1947,6 +1947,7 @@ virDomainChrDefParseXML(virConnectPtr conn,
             virDomainReportError(conn, VIR_ERR_XML_ERROR,
                               _("unknown target type for character device: %s"),
                                  nodeName);
+            VIR_FREE(def);
             return NULL;
         }
         def->targetType = VIR_DOMAIN_CHR_TARGET_TYPE_NULL;