From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Date: Sat, 18 Feb 2012 05:56:21 +0000 (-0200)
Subject: Add missing newlines
X-Git-Tag: v6~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=050db08c57c10cb964d337c5668c4dce309b8d41;p=thirdparty%2Fkmod.git

Add missing newlines

Checked with following semantic patch for the library:

// smpl
@a@
identifier virtual.func;
expression E1;
expression fmt;
position p1;
@@

func(E1, fmt@p1, ...)

@script:python b@
fmt << a.fmt;
p1 << a.p1;
@@

s = str(fmt)
if s.find("\\n") < 0:
	print p1[0].file + ":" + p1[0].line

// smpl

For tools, just remove E1
---

diff --git a/libkmod/libkmod-config.c b/libkmod/libkmod-config.c
index ac9c888d..f2ad4b43 100644
--- a/libkmod/libkmod-config.c
+++ b/libkmod/libkmod-config.c
@@ -568,7 +568,7 @@ static int kmod_config_parse(struct kmod_config *config, int fd,
 	fp = fdopen(fd, "r");
 	if (fp == NULL) {
 		err = -errno;
-		ERR(config->ctx, "fd %d: %m", fd);
+		ERR(config->ctx, "fd %d: %m\n", fd);
 		close(fd);
 		return err;
 	}
diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
index 4226bbb1..637b7921 100644
--- a/libkmod/libkmod-module.c
+++ b/libkmod/libkmod-module.c
@@ -1012,7 +1012,8 @@ static int __kmod_module_fill_softdep(struct kmod_module *mod,
 
 	err = kmod_module_get_softdeps(mod, &pre, &post);
 	if (err < 0) {
-		ERR(mod->ctx, "could not get softdep: %s", strerror(-err));
+		ERR(mod->ctx, "could not get softdep: %s\n",
+							strerror(-err));
 		goto fail;
 	}
 
diff --git a/testsuite/testsuite.c b/testsuite/testsuite.c
index c330e4c6..9efe8ded 100644
--- a/testsuite/testsuite.c
+++ b/testsuite/testsuite.c
@@ -205,7 +205,7 @@ static inline int test_run_child(const struct test *t, int fdout[2],
 	if (t->output.stdout != NULL) {
 		close(fdout[0]);
 		if (dup2(fdout[1], STDOUT_FILENO) < 0) {
-			ERR("could not redirect stdout to pipe: %m");
+			ERR("could not redirect stdout to pipe: %m\n");
 			exit(EXIT_FAILURE);
 		}
 	}
@@ -213,7 +213,7 @@ static inline int test_run_child(const struct test *t, int fdout[2],
 	if (t->output.stderr != NULL) {
 		close(fderr[0]);
 		if (dup2(fderr[1], STDERR_FILENO) < 0) {
-			ERR("could not redirect stdout to pipe: %m");
+			ERR("could not redirect stdout to pipe: %m\n");
 			exit(EXIT_FAILURE);
 		}
 	}
@@ -458,7 +458,7 @@ static int prepend_path(const char *extra)
 		return setenv("PATH", extra, 1);
 
 	if (asprintf(&newpath, "%s:%s", extra, oldpath) < 0) {
-		ERR("failed to allocate memory to new PATH");
+		ERR("failed to allocate memory to new PATH\n");
 		return -1;
 	}