From: Vsevolod Stakhov <vsevolod@rspamd.com>
Date: Mon, 16 Feb 2026 19:08:55 +0000 (+0000)
Subject: [Fix] Fix JSON emission for implicit arrays in libucl
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0511e24c113ae44c6f09707a61de8352d45e1bb3;p=thirdparty%2Frspamd.git

[Fix] Fix JSON emission for implicit arrays in libucl

When emitting UCL objects with implicit arrays (multiple values for the
same key) as JSON, the emitter was producing invalid output by:
- Not printing the key before the array for non-first elements
- Missing comma separators between elements

This caused rspamadm configdump -j to output malformed JSON like:
  "actions": {...}[
instead of:
  "actions": {...},
  "group": [
---

diff --git a/contrib/libucl/ucl_emitter.c b/contrib/libucl/ucl_emitter.c
index 2c179694d5..fb90adcb8b 100644
--- a/contrib/libucl/ucl_emitter.c
+++ b/contrib/libucl/ucl_emitter.c
@@ -323,10 +323,16 @@ ucl_emitter_common_start_object(struct ucl_emitter_context *ctx,
 		else {
 			/* Expand implicit arrays */
 			if (cur->next != NULL) {
-				if (first) {
-					ucl_add_tabs(func, ctx->indent, compact);
+				if (!first) {
+					if (compact) {
+						func->ucl_emitter_append_character(',', 1, func->ud);
+					}
+					else {
+						func->ucl_emitter_append_len(",\n", 2, func->ud);
+					}
 				}
-				ucl_emitter_common_start_array(ctx, cur, first, compact);
+				ucl_add_tabs(func, ctx->indent, compact);
+				ucl_emitter_common_start_array(ctx, cur, true, compact);
 				ucl_emitter_common_end_array(ctx, cur, compact);
 			}
 			else {