From: James Jones <jejones3141@gmail.com>
Date: Thu, 25 Jul 2024 20:51:38 +0000 (-0500)
Subject: Check fr_size_to_str() return in kafka_config_dflt_single (CID #1604624)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=051394904cd11767ca7f9ddafab5042191e76f5c;p=thirdparty%2Ffreeradius-server.git

Check fr_size_to_str() return in kafka_config_dflt_single (CID #1604624)
---

diff --git a/src/lib/kafka/base.c b/src/lib/kafka/base.c
index 2604532ca9b..1c5b31927d4 100644
--- a/src/lib/kafka/base.c
+++ b/src/lib/kafka/base.c
@@ -175,7 +175,13 @@ static int kafka_config_dflt_single(CONF_PAIR **out, UNUSED void *parent, CONF_S
 		 */
 		if (kctx->size_scale) size *= kctx->size_scale;
 
-		fr_size_to_str(&value_elem, size);	/* reprint the size with an appropriate unit */
+		/*
+		 * 	reprint the size with an appropriate unit
+		 */
+		if (fr_size_to_str(&value_elem, size) < 0) {
+			cf_log_perr(cs, "Failed size reprint");
+			return -1;
+		}
 		value = fr_sbuff_start(&value_elem);
 	}
 		break;