From: Bart Van Assche <bvanassche@acm.org>
Date: Sun, 10 Jun 2012 10:44:05 +0000 (+0000)
Subject: drd: Don't sporadically report false positives on newly allocated memory. Fixes ... 
X-Git-Tag: svn/VALGRIND_3_8_0~239
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=051e39f840b8a34ca6d446e627d44daa2d93e1fa;p=thirdparty%2Fvalgrind.git

drd: Don't sporadically report false positives on newly allocated memory. Fixes #297147.


git-svn-id: svn://svn.valgrind.org/valgrind/trunk@12629
---

diff --git a/drd/drd_main.c b/drd/drd_main.c
index 7c7ef9fc36..70184c591c 100644
--- a/drd/drd_main.c
+++ b/drd/drd_main.c
@@ -325,8 +325,21 @@ void drd_start_using_mem(const Addr a1, const SizeT len,
                       a1, len, DRD_(running_thread_inside_pthread_create)()
                       ? " (inside pthread_create())" : "");
 
+#if 0
    if (!is_stack_mem && DRD_(g_free_is_write))
       DRD_(thread_stop_using_mem)(a1, a2);
+#else
+   /*
+    * Sometimes it happens that a client starts using a memory range that has
+    * been accessed before but for which drd_stop_using_mem() has not been
+    * called for the entire range. It is not yet clear whether this is an
+    * out-of-range access by the client, an issue in the Valgrind core or an
+    * issue in DRD. Avoid that this issue triggers false positive reports by
+    * always clearing accesses for newly allocated memory ranges. See also
+    * http://bugs.kde.org/show_bug.cgi?id=297147.
+    */
+   DRD_(thread_stop_using_mem)(a1, a2);
+#endif
 
    if (UNLIKELY(DRD_(any_address_is_traced)()))
    {