From: Selva Nair <selva.nair@gmail.com>
Date: Mon, 5 Mar 2018 15:28:00 +0000 (-0500)
Subject: Management: warn about password only when the option is in use
X-Git-Tag: v2.4.6~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0533bd715bc3865019a718fbe512f86e0a907103;p=thirdparty%2Fopenvpn.git

Management: warn about password only when the option is in use

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1520263680-1260-1-git-send-email-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16631.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 5961250e776194a411a8dfc1670c5c0c73107bf8)
---

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index a0076309c..d1adfb658 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -2190,7 +2190,8 @@ options_postprocess_verify_ce(const struct options *options, const struct connec
         msg(M_USAGE, "--management-client-(user|group) can only be used on unix domain sockets");
     }
 
-    if (!(options->management_flags & MF_UNIX_SOCK)
+    if (options->management_addr
+        && !(options->management_flags & MF_UNIX_SOCK)
         && (!options->management_user_pass))
     {
         msg(M_WARN, "WARNING: Using --management on a TCP port WITHOUT "