From: Michal Privoznik <mprivozn@redhat.com>
Date: Fri, 2 Oct 2020 08:37:26 +0000 (+0200)
Subject: virfirewalltest: Don't duplicate string when adding it onto stringlist
X-Git-Tag: v6.9.0-rc1~405
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=053beeb04de2d238c115b3bd4cc8f4ccc3d83d43;p=thirdparty%2Flibvirt.git

virfirewalltest: Don't duplicate string when adding it onto stringlist

In our wrapper of g_dbus_connection_call_sync() in
virfirewalltest a string is duplicated and added onto a
virStringList. This leads to a memory leak because
virStringListAdd() duplicates the string itself.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
---

diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c
index 646b999d96..dc631dfc5d 100644
--- a/tests/virfirewalltest.c
+++ b/tests/virfirewalltest.c
@@ -122,7 +122,7 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync,
                 doError = true;
             }
 
-            virStringListAdd(&args, g_strdup(item));
+            virStringListAdd(&args, item);
         }
 
         if (fwBuf) {