From: traud <pabstraud@compuserve.com>
Date: Fri, 3 Apr 2020 17:25:37 +0000 (+0200)
Subject: chan_unistim: Avoid tautological warnings with clang.
X-Git-Tag: 13.33.0-rc1~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=05440f3ef62ddc8d8d3dfbf18701a84dad29e897;p=thirdparty%2Fasterisk.git

chan_unistim: Avoid tautological warnings with clang.

ASTERISK-28803

Change-Id: I15449621b68d0ad4d57b7c337c1167adb15135af
---

diff --git a/channels/chan_unistim.c b/channels/chan_unistim.c
index 3b70cf9643..a08769e625 100644
--- a/channels/chan_unistim.c
+++ b/channels/chan_unistim.c
@@ -1353,7 +1353,7 @@ static void refresh_all_favorite(struct unistimsession *pte)
 
 static int is_key_favorite(struct unistim_device *d, int fav)
 {
-	if ((fav < 0) && (fav > 5)) {
+	if ((fav < 0) || (fav >= FAVNUM)) {
 		return 0;
 	}
 	if (d->sline[fav]) {
@@ -1367,7 +1367,7 @@ static int is_key_favorite(struct unistim_device *d, int fav)
 
 static int is_key_line(struct unistim_device *d, int fav)
 {
-	if ((fav < 0) && (fav > 5)) {
+	if ((fav < 0) || (fav >= FAVNUM)) {
 		return 0;
 	}
 	if (!d->sline[fav]) {