From: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Date: Wed, 24 Apr 2019 09:51:18 +0000 (+0300)
Subject: conf: add cpu check attribute to ABI check
X-Git-Tag: v5.3.0-rc1~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=055af76f164f265db68c671533b293c4a475ca91;p=thirdparty%2Flibvirt.git

conf: add cpu check attribute to ABI check

Different check values are not ABI compatible. For example
if on migration we change 'full' to 'partial' then guest cpu
on destination can be different.

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
---

diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 33c8b99e49..bd2beab33e 100644
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -894,6 +894,13 @@ virCPUDefIsEqual(virCPUDefPtr src,
         goto cleanup;
     }
 
+    if (src->check != dst->check) {
+        MISMATCH(_("Target CPU check %s does not match source %s"),
+                 virCPUCheckTypeToString(dst->check),
+                 virCPUCheckTypeToString(src->check));
+        goto cleanup;
+    }
+
     if (src->arch != dst->arch) {
         MISMATCH(_("Target CPU arch %s does not match source %s"),
                  virArchToString(dst->arch),