From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Tue, 25 Jan 2022 20:21:56 +0000 (+0100)
Subject: MINOR: quic: Comment fix about the token found in Initial packets
X-Git-Tag: v2.6-dev1~62
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=055ee6c14b18054a1a0b4823333bee1b3e6a9bab;p=thirdparty%2Fhaproxy.git

MINOR: quic: Comment fix about the token found in Initial packets

Mention that the token is sent only by servers in both server and listener
packet parsers.
Remove a "TO DO" section in listener packet parser because there is nothing
more to do in this function about the token
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index d021f62d10..8a9b4f2937 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -3942,7 +3942,8 @@ static ssize_t qc_srv_pkt_rcv(unsigned char **buf, const unsigned char *end,
 			 * So, a client which receives an Initial packet with a token
 			 * MUST discard the packet or generate a connection error with
 			 * PROTOCOL_VIOLATION as type.
-			 * The token must be provided in a Retry packet or NEW_TOKEN frame.
+			 * The token may be provided in a Retry packet or NEW_TOKEN frame
+			 * only by the QUIC server.
 			 */
 			pkt->token_len = token_len;
 		}
@@ -4429,12 +4430,8 @@ static ssize_t qc_lstnr_pkt_rcv(unsigned char *buf, const unsigned char *end,
 				goto err;
 			}
 
-			/* XXX TO DO XXX 0 value means "the token is not present".
-			 * A server which sends an Initial packet must not set the token.
-			 * So, a client which receives an Initial packet with a token
-			 * MUST discard the packet or generate a connection error with
-			 * PROTOCOL_VIOLATION as type.
-			 * The token must be provided in a Retry packet or NEW_TOKEN frame.
+			/* The token may be provided in a Retry packet or NEW_TOKEN frame
+			 * only by the QUIC server.
 			 */
 			pkt->token_len = token_len;