From: Jeremy Allison <jra@samba.org>
Date: Tue, 8 Sep 2020 23:22:21 +0000 (-0700)
Subject: s3: libsmb: Remove get_kdc_list(). No more callers.
X-Git-Tag: talloc-2.3.2~518
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0562154afadf9dcb9327f4019d58a166f85e7adf;p=thirdparty%2Fsamba.git

s3: libsmb: Remove get_kdc_list(). No more callers.

Next we can rename get_kdc_list_sa() -> get_kdc_list().

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <noel.power@suse.com>
---

diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c
index 0437428d995..b590cb413aa 100644
--- a/source3/libsmb/namequery.c
+++ b/source3/libsmb/namequery.c
@@ -4211,44 +4211,6 @@ NTSTATUS get_sorted_dc_list(TALLOC_CTX *ctx,
 	return status;
 }
 
-/*********************************************************************
- Talloc version.
- Get the KDC list - re-use all the logic in get_dc_list.
-*********************************************************************/
-
-NTSTATUS get_kdc_list(TALLOC_CTX *ctx,
-			const char *realm,
-			const char *sitename,
-			struct ip_service **ip_list_ret,
-			size_t *ret_count)
-{
-	size_t count = 0;
-	struct ip_service *ip_list = NULL;
-	bool ordered = false;
-	NTSTATUS status;
-
-	status = get_dc_list(ctx,
-			realm,
-			sitename,
-			&ip_list,
-			&count,
-			DC_KDC_ONLY,
-			&ordered);
-
-	if (!NT_STATUS_IS_OK(status)) {
-		return status;
-	}
-
-	/* only sort if we don't already have an ordered list */
-	if (!ordered ) {
-		sort_service_list(ip_list, count);
-	}
-
-	*ret_count = count;
-	*ip_list_ret = ip_list;
-	return status;
-}
-
 /*********************************************************************
  Get the KDC list - re-use all the logic in get_dc_list.
  Returns a samba_sockaddr array.
diff --git a/source3/libsmb/namequery.h b/source3/libsmb/namequery.h
index 29277437f77..299a5ebc04f 100644
--- a/source3/libsmb/namequery.h
+++ b/source3/libsmb/namequery.h
@@ -116,11 +116,6 @@ NTSTATUS get_sorted_dc_list(TALLOC_CTX *ctx,
 			struct ip_service **ip_list_ret,
 			size_t *ret_count,
 			bool ads_only);
-NTSTATUS get_kdc_list(TALLOC_CTX *ctx,
-			const char *realm,
-			const char *sitename,
-			struct ip_service **ip_list_ret,
-			size_t *ret_count);
 NTSTATUS get_kdc_list_sa(TALLOC_CTX *ctx,
 			const char *realm,
 			const char *sitename,