From: Iker Pedrosa <ipedrosa@redhat.com>
Date: Tue, 26 Apr 2022 14:45:04 +0000 (+0200)
Subject: Suggest badname if name has special characters
X-Git-Tag: 4.12~43
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0593b330d8413e9694b5d6783bb90974c9b141c5;p=thirdparty%2Fshadow.git

Suggest badname if name has special characters

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2076819

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
---

diff --git a/src/newusers.c b/src/newusers.c
index 8e7c620dc..8c882100a 100644
--- a/src/newusers.c
+++ b/src/newusers.c
@@ -383,7 +383,7 @@ static int add_user (const char *name, uid_t uid, gid_t gid)
 	/* Check if this is a valid user name */
 	if (!is_valid_user_name (name)) {
 		fprintf (stderr,
-		         _("%s: invalid user name '%s'\n"),
+		         _("%s: invalid user name '%s': use --badname to ignore\n"),
 		         Prog, name);
 		return -1;
 	}
diff --git a/src/pwck.c b/src/pwck.c
index 22b1fdcd8..058a240e2 100644
--- a/src/pwck.c
+++ b/src/pwck.c
@@ -470,7 +470,8 @@ static void check_pw_file (int *errors, bool *changed)
 		 */
 
 		if (!is_valid_user_name (pwd->pw_name)) {
-			printf (_("invalid user name '%s'\n"), pwd->pw_name);
+			printf (_("invalid user name '%s': use --badname to ignore\n"),
+					pwd->pw_name);
 			*errors += 1;
 		}
 
diff --git a/src/usermod.c b/src/usermod.c
index af2208be3..459d8acf0 100644
--- a/src/usermod.c
+++ b/src/usermod.c
@@ -1095,7 +1095,7 @@ static void process_flags (int argc, char **argv)
 			case 'l':
 				if (!is_valid_user_name (optarg)) {
 					fprintf (stderr,
-					         _("%s: invalid user name '%s'\n"),
+					         _("%s: invalid user name '%s': use --badname to ignore\n"),
 					         Prog, optarg);
 					exit (E_BAD_ARG);
 				}