From: Frédéric Buclin <LpSolit@gmail.com>
Date: Wed, 17 Dec 2014 19:37:55 +0000 (+0100)
Subject: Bug 1111043: Bug.add_comment returns the wrong comment ID
X-Git-Tag: release-5.1.1~413
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0598a0af385f90fdbc6f7a59fb5edb007394b73c;p=thirdparty%2Fbugzilla.git

Bug 1111043: Bug.add_comment returns the wrong comment ID
r=dkl a=glob
---

diff --git a/Bugzilla/WebService/Bug.pm b/Bugzilla/WebService/Bug.pm
index de358b1e02..3d7ff38045 100644
--- a/Bugzilla/WebService/Bug.pm
+++ b/Bugzilla/WebService/Bug.pm
@@ -981,19 +981,10 @@ sub add_comment {
     $bug->add_comment($comment, { isprivate   => $params->{is_private},
                                   is_markdown => $params->{is_markdown},
                                   work_time   => $params->{work_time} });
-    
-    # Capture the call to bug->update (which creates the new comment) in 
-    # a transaction so we're sure to get the correct comment_id.
-    
-    my $dbh = Bugzilla->dbh;
-    $dbh->bz_start_transaction();
-    
     $bug->update();
-    
-    my $new_comment_id = $dbh->bz_last_key('longdescs', 'comment_id');
-    
-    $dbh->bz_commit_transaction();
-    
+
+    my $new_comment_id = $bug->{added_comments}[0]->id;
+
     # Send mail.
     Bugzilla::BugMail::Send($bug->bug_id, { changer => $user });