From: Baptiste Daroussin <bapt@FreeBSD.org>
Date: Wed, 8 Mar 2023 17:14:23 +0000 (+0100)
Subject: mlmmj-process: avoid useless memory allocation
X-Git-Tag: RELEASE_1_4_0b1~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=05a3d680e1fe6665aa804e751fce123d096c0a38;p=thirdparty%2Fmlmmj.git

mlmmj-process: avoid useless memory allocation
---

diff --git a/src/mlmmj-process.c b/src/mlmmj-process.c
index 5f577e6b..fbaf68d1 100644
--- a/src/mlmmj-process.c
+++ b/src/mlmmj-process.c
@@ -388,7 +388,8 @@ int main(int argc, char **argv)
 	char *queuefilename, *recipextra = NULL, *owner = NULL;
 	char *maxmailsizestr;
 	char *subject = NULL, *posteraddr = NULL;
-	char *envstr, *efrom;
+	char *envstr;
+	const char *efrom = "";
 	struct stat st;
 	strlist fromemails = tll_init();
 	strlist originalfromemails = tll_init();
@@ -626,12 +627,10 @@ int main(int argc, char **argv)
 	/* envelope from */
 	if((envstr = getenv("SENDER")) != NULL) {
 		/* qmail, postfix, exim */
-		efrom = xstrdup(envstr);
+		efrom = envstr;
 	} else if(tll_length(rpemails) >= 1) {
 		/* the (first) Return-Path: header */
-		efrom = xstrdup(tll_front(rpemails));
-	} else {
-		efrom = xstrdup("");
+		efrom = tll_front(rpemails);
 	}
 
 	/* Subject: */
@@ -737,7 +736,7 @@ int main(int argc, char **argv)
 
 	free(delheaders);
 
-	if(strcmp(efrom, "") == 0) { /* don't send mails with <> in From
+	if(*efrom == '\0') { /* don't send mails with <> in From
 					     to the list */
 		xasprintf(&discardname, "%s/queue/discardrd/%s", ml.dir, randomstr);
 		errno = 0;