From: Pavel Begunkov Date: Fri, 9 May 2025 11:12:49 +0000 (+0100) Subject: io_uring: simplify drain ret passing X-Git-Tag: v6.16-rc1~215^2~25 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=05b334110fdc85f536d7dd573120d573801fb2d1;p=thirdparty%2Flinux.git io_uring: simplify drain ret passing "ret" in io_drain_req() is only used in one place, remove it and pass -ENOMEM directly. Signed-off-by: Pavel Begunkov Link: https://lore.kernel.org/r/ece724b77e66e6caabcc215e0032ee7ff140f289.1746788718.git.asml.silence@gmail.com Signed-off-by: Jens Axboe --- diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 7491793c80bac..6b606e9dffa39 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -1672,7 +1672,6 @@ static __cold void io_drain_req(struct io_kiocb *req) { struct io_ring_ctx *ctx = req->ctx; struct io_defer_entry *de; - int ret; u32 seq = io_get_sequence(req); /* Still need defer if there is pending req in defer list. */ @@ -1689,8 +1688,7 @@ queue: io_prep_async_link(req); de = kmalloc(sizeof(*de), GFP_KERNEL_ACCOUNT); if (!de) { - ret = -ENOMEM; - io_req_defer_failed(req, ret); + io_req_defer_failed(req, -ENOMEM); return; }