From: John Ferlan <jferlan@redhat.com>
Date: Wed, 14 Feb 2018 12:12:35 +0000 (-0500)
Subject: test: Check return status for libxlxml2domconfigtest
X-Git-Tag: v4.5.0-rc1~168
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=05c41f4f1d47f97c979a94e2fea2c9186a8f9196;p=thirdparty%2Flibvirt.git

test: Check return status for libxlxml2domconfigtest

Commit id d8e8b63d introduced the test, but neglected to check for
error from virTestLoadFile in testCompareXMLToDomConfig.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Katerina Koukiou <kkoukiou@redhat.com>
---

diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c
index 0d2a7385e5..54a92cc959 100644
--- a/tests/libxlxml2domconfigtest.c
+++ b/tests/libxlxml2domconfigtest.c
@@ -104,7 +104,9 @@ testCompareXMLToDomConfig(const char *xmlfile,
         goto cleanup;
     }
 
-    virTestLoadFile(jsonfile, &tempjson);
+    if (virTestLoadFile(jsonfile, &tempjson) < 0)
+        goto cleanup;
+
     if (libxl_domain_config_from_json(cfg->ctx, &expectconfig, tempjson) != 0) {
         virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                        "Failed to create libxl_domain_config from JSON doc");