From: Dan Carpenter Date: Wed, 29 Oct 2025 13:13:56 +0000 (+0300) Subject: misc: cb710: Fix a NULL vs IS_ERR() check in probe() X-Git-Tag: v6.19-rc1~65^2~10 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=05d36a5931d92310819e64fdee0cc1a35e14944c;p=thirdparty%2Fkernel%2Flinux.git misc: cb710: Fix a NULL vs IS_ERR() check in probe() The pcim_iomap_region() function never returns NULL, it returns error pointers. Update the checking to match. Fixes: b91c13534a63 ("misc: cb710: Replace deprecated PCI functions") Signed-off-by: Dan Carpenter Acked-by: Arnd Bergmann Link: https://patch.msgid.link/aQITFDPyuzjNN4GN@stanley.mountain Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/cb710/core.c b/drivers/misc/cb710/core.c index a1e6ba62c2980..2dd212f04fed2 100644 --- a/drivers/misc/cb710/core.c +++ b/drivers/misc/cb710/core.c @@ -226,8 +226,8 @@ static int cb710_probe(struct pci_dev *pdev, spin_lock_init(&chip->irq_lock); chip->pdev = pdev; chip->iobase = pcim_iomap_region(pdev, 0, KBUILD_MODNAME); - if (!chip->iobase) - return -ENOMEM; + if (IS_ERR(chip->iobase)) + return PTR_ERR(chip->iobase); pci_set_drvdata(pdev, chip);