From: Neil Horman Date: Wed, 29 Jan 2025 19:19:35 +0000 (-0500) Subject: Move quictestlib TODO to QUIC FUTURE X-Git-Tag: openssl-3.5.0-alpha1~219 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=05ea15261c6d18df4345785ae1a15799f7a3bace;p=thirdparty%2Fopenssl.git Move quictestlib TODO to QUIC FUTURE Improving handling of packets in tserver doesn't currently make sense, as we're planning on eliminating it soon. Move this TODO to QUIC FUTURE Fixes openssl/project#1070 Reviewed-by: Matt Caswell Reviewed-by: Saša Nedvědický (Merged from https://github.com/openssl/openssl/pull/26593) --- diff --git a/test/helpers/quictestlib.c b/test/helpers/quictestlib.c index 83fe29c78cf..7e2882a75f7 100644 --- a/test/helpers/quictestlib.c +++ b/test/helpers/quictestlib.c @@ -264,13 +264,7 @@ int qtest_create_quic_objects(OSSL_LIB_CTX *libctx, SSL_CTX *clientctx, 0, &now_cb), 1)) goto err; } - /* - * TODO(QUIC SERVER): - * Currently the simplistic handler of the quic tserver cannot cope - * with noise introduced in the first packet received from the - * client. This needs to be removed once we have proper server side - * handling. - */ + (void)BIO_ctrl(sbio, BIO_CTRL_NOISE_BACK_OFF, 0, NULL); (*fault)->noiseargs.cbio = cbio;