From: Simon McVittie Date: Wed, 26 Jan 2011 18:38:01 +0000 (+0000) Subject: dbus_connection_dispatch: remove dead code X-Git-Tag: dbus-1.4.10~20 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=05f822e3fb7eaeb2801f6a7b178395937a2a20c5;p=thirdparty%2Fdbus.git dbus_connection_dispatch: remove dead code There's no way pending can be non-NULL here; if it was, we'd have jumped straight past this block (getting filters from the connection), because replies to pending calls don't go through filters. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33128 Reviewed-by: Cosimo Alfarano --- diff --git a/dbus/dbus-connection.c b/dbus/dbus-connection.c index e656cd2a9..d0aca256c 100644 --- a/dbus/dbus-connection.c +++ b/dbus/dbus-connection.c @@ -4613,9 +4613,6 @@ dbus_connection_dispatch (DBusConnection *connection) /* unlocks and calls user code */ _dbus_connection_update_dispatch_status_and_unlock (connection, DBUS_DISPATCH_NEED_MEMORY); - - if (pending) - dbus_pending_call_unref (pending); dbus_connection_unref (connection); return DBUS_DISPATCH_NEED_MEMORY;