From: Tobias Brunner <tobias@strongswan.org>
Date: Mon, 15 Jul 2024 14:55:29 +0000 (+0200)
Subject: unit-tests: Fix compiler warning with empty message assertion
X-Git-Tag: android-2.5.2~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0602ed10439776c540e5bf3d0b92aa04568295df;p=thirdparty%2Fstrongswan.git

unit-tests: Fix compiler warning with empty message assertion

The empty array of rules for `assert_message_empty()` and the resulting
size 0 triggers warnings like these:

  allocation of insufficient size '0' for type 'listener_message_rule_t' with size '12'

Using calloc() with `nmemb` set to 0 triggers the same warning.
---

diff --git a/src/libcharon/tests/utils/exchange_test_asserts.h b/src/libcharon/tests/utils/exchange_test_asserts.h
index a58832d733..e4ce810403 100644
--- a/src/libcharon/tests/utils/exchange_test_asserts.h
+++ b/src/libcharon/tests/utils/exchange_test_asserts.h
@@ -357,7 +357,7 @@ bool exchange_test_asserts_message(listener_t *this, ike_sa_t *ike_sa,
 		.line = __LINE__, \
 		.incoming = streq(dir, "IN") ? TRUE : FALSE, \
 		.count = c, \
-		.rules = malloc(sizeof(_rules)), \
+		.rules = sizeof(_rules) ? malloc(sizeof(_rules)) : NULL, \
 		.num_rules = countof(_rules), \
 	); \
 	memcpy(_listener->rules, _rules, sizeof(_rules)); \